Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile to support fuel-core run #467

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

ControlCplusControlV
Copy link
Contributor

No description provided.

@ControlCplusControlV ControlCplusControlV marked this pull request as draft July 8, 2022 02:24
@ControlCplusControlV ControlCplusControlV changed the title maybe works Docker Fix for Kube Jul 8, 2022
@ControlCplusControlV ControlCplusControlV changed the title Docker Fix for Kube Fix Dockerfile to support fuel-core run Jul 8, 2022
@ControlCplusControlV ControlCplusControlV added the bug Something isn't working label Jul 8, 2022
@ControlCplusControlV ControlCplusControlV marked this pull request as ready for review July 8, 2022 13:21
@ControlCplusControlV
Copy link
Contributor Author

Requesting review from someone on infra team to confirm

@Voxelot
Copy link
Member

Voxelot commented Jul 8, 2022

fyi the client team should take ownership of dockerfile / deployment scripts related to fuel-core and not distract infra team with minor changes like these.

Testing this out will be easier once ephemeral envs are further along, allowing us to automatically spin up preview envs from a PR. Till then you can do a manual deployment to the CD env using this PR or just wait and see if it works once merged to master.

@ControlCplusControlV ControlCplusControlV merged commit bbfd1ce into master Jul 8, 2022
@ControlCplusControlV ControlCplusControlV deleted the controlc/fix_docker branch July 8, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants