-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger Ephemeral Test Workflows #506
Conversation
TEST RESULTS:
Fuel Core Action: https://github.com/FuelLabs/fuel-core/actions/runs/2864783926 Fuel Deployment Action: https://github.com/FuelLabs/fuel-deployment/actions/runs/2864820823 % kubectl get ns % kubectl get deployment fuel-core-k8s -o yaml -n fuel-core-preview-create-eph-envs-workflows | grep image % helm list --namespace fuel-core-preview-create-eph-envs-workflows % kubectl get all -n fuel-core-preview-create-eph-envs-workflows NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE NAME READY UP-TO-DATE AVAILABLE AGE NAME DESIRED CURRENT READY AGE
Hence Delete Eph ENV "fuel-core-preview-create-eph-envs-workflows" namespace Fuel Core Action: https://github.com/FuelLabs/fuel-core/actions/runs/2864840718 Fuel Deployment Action: https://github.com/FuelLabs/fuel-deployment/actions/runs/2864841647 % kubectl get ns |
This looks good but I have one concern with this approach. If we build the docker image for fuel-core when the PR is opened, this will bypass our normal flow for only building the docker image after unit tests and other CI checks have passed. I'll request the following changes:
|
the logic suggested has been implemented here is using ci.yaml to deploy to new ephemeral env using sha image tag built: https://github.com/FuelLabs/fuel-core/actions/runs/3120881863 |
@Voxelot - can I get a review please of this ? thanks |
The changes here look good, this is exactly what I had in mind 👍🏻 Any idea why nginx is returning a 404? http://fuel-core-preview-create-eph-envs-worksflows.swayswap.io/health I was able to port-forward to Is it possible the long URL is causing problems? |
Another last-minute thought I had, is that we should use a branch prefix scheme to selectively enable these jobs. That way PRs unrelated to code changes (such as docs / readme updates) don't thrash our dev cluster. This could be a prefix like |
Remotely dispatch Deploy and Delete Test Workflow Environments in Fuel-Deployment
Deploy ephemeral test workflow: