add db column for message owner #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
Aug 4, 2022
| @@ -13,12 +19,31 @@ impl Storage<MessageId, DaMessage> for Database { | |||
| key: &MessageId, | |||
| value: &DaMessage, | |||
| ) -> Result<Option<DaMessage>, KvStoreError> { | |||
| // insert secondary record by owner | |||
| Database::insert( | |||
There was a problem hiding this comment.
It seems like we should do the primary insert of the record before the updating the index. Just in case something tries to query the index and the underlying data isn't persisted yet.
Voxelot
previously approved these changes
Aug 4, 2022
Voxelot
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #520
insert()andremove()methods so that MessageIds get persistedowned_message_ids()query method to the Database