-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch all messages and messages by owner #536
Conversation
…beak/fetch_all_messages
This could just be me, but when I run the new test under
However, this message isn't exactly an error: the test execution still runs and the the test still passes. It appears to be something to do with using bincode to deserialize the metadata for // fuel-core/src/database/metadata.rs
self.insert(VALIDATORS_DA_HEIGHT_KEY, METADATA, 0)?;
..
// fuel-core/src/database.rs
// self.get calls bincode::deserialize
match self.get(metadata::VALIDATORS_DA_HEIGHT_KEY, METADATA) {
..
Err(err) => {
panic!(
"get_validators_da_height database corruption, err:{:?}",
err
);
}
} Is anyone else seeing this? |
Yeah this is a bug in the relayer code, i disabled the relayer by default in @ControlCplusControlV's branch |
I'm thinking we could consolidate these two pagination endpoints by providing an optional |
here are my proposed changes to consolidate the two interfaces. When no owner is passed, it behaves normally as if iterating over the entire set of messages. When an owner is supplied to the API, the messages will be filtered based on the owner. |
WIP
solves #521
DONE:
all_owners_and_message_ids()
to the DatabaseMessageQuery
that includesmessages()
andmessages_by_owner()
TODO
exposemessages()
andmessages_by_owner()
APIs within fuel-clientfinish the test infuel-tests/tests/messages