Refactored usage of storage traits #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
force-pushed
the
feature/split-storage-trait
branch
2 times, most recently
from
25b042a to
b336c22
Compare
xgreenx
changed the title
Refactored all tables to implement new storage traits(Also refactored all tests).
Replaced all `<Self as Storage<K, V>>::method` with `self.storage::<Table>().method`.
The same for `MerkleRootStorage`. Also refactored all tests.
Instead of constants for columns, use the `Column` enum to manage tables columns(Use `Column`
everywhere instead of `ColumnId`). In the future, we can use more advanced naming for fields,
instead of "column-{i}" because now we have names of enum=)
In some places, removed unnecessary usage of `Vec<u8>`(in `put`, `insert` etc methods).
Removed usage of `Clone` and `Copy` for some `value` in the same methods.
Prepared the code for the next refactoring:
- to simplify the implementation of storage-related traits
- to use only read/write traits in the places where it is really required
- performance improvements to work with types more optimal
Update stable rust to 1.63 to support enum-iterator
xgreenx
force-pushed
the
feature/split-storage-trait
branch
from
cc6bbf9 to
bedddb5
Compare
# Conflicts: # fuel-core-interfaces/Cargo.toml # fuel-core/src/database/storage/message.rs
Updated `fuel-vm` to `0.18`. Renamed all columns to be according with the table. Added description to each `Column`. Added more description to tables.
# Conflicts: # fuel-client/Cargo.toml # fuel-core-interfaces/Cargo.toml # fuel-core-interfaces/src/db.rs # fuel-core-interfaces/src/relayer.rs # fuel-core-interfaces/src/txpool.rs # fuel-core/Cargo.toml
Voxelot
reviewed
Sep 13, 2022
Voxelot
reviewed
Sep 13, 2022
Voxelot
reviewed
Sep 13, 2022
Voxelot
reviewed
Sep 13, 2022
Voxelot
reviewed
Sep 13, 2022
Voxelot
reviewed
Sep 14, 2022
Merged
…o feature/split-storage-trait
vlopes11
reviewed
Sep 14, 2022
| @@ -3,7 +3,7 @@ use async_trait::async_trait; | |||
| use thiserror::Error; | |||
|
|
|||
| /// Dummy signer that will be removed in next pull request. | |||
| /// TODO do not use. | |||
| /// TODO: Do not use. | |||
There was a problem hiding this comment.
Unrelated to this PR as well, but isn't a bit weird that we have a public trait that should not be used? Shouldn't we make it private or something?
Voxelot
reviewed
Sep 14, 2022
Voxelot
reviewed
Sep 14, 2022
Voxelot
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored all tables to implement new storage traits(Also refactored all tests). Created types for all tables with descriptions and re-used tables defined in the
fuel-vm.Replaced all
<Self as Storage<K, V>>::methodwithself.storage::<Table>().method.The same for
MerkleRootStorageand tests.Instead of constants for columns, use the
Columnenum to manage tables columns(UseColumneverywhere instead of
ColumnId). In the future, we can use more advanced naming for fields,instead of "column-{i}" because now we have names of cloumns=)
In some places, removed unnecessary usage of
Vec<u8>(input,insertetc methods).Removed usage of
CloneandCopyfor somevaluein the same methods.Prepared the code for the next refactoring: