Add a CI check to ensure Cargo.lock file remains up-to-date #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new CI "cargo-verification" check to ensure the `Cargo.lock` file is valid for the current state of all manifests within the workspace. This avoids having `Cargo.lock` files changes leak into unrelated PRs, and allows tools like Nix to always have a valid lock file present at each published release to ensure reproducible builds.
Dentosal
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Cargo docs specifically say that this is a good idea: https://doc.rust-lang.org/cargo/commands/cargo-check.html#manifest-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new CI "cargo-verification" check to ensure the
Cargo.lockfile is valid for the current state of all manifests within the workspace. This avoids havingCargo.lockfiles changes leak into unrelated PRs, and allows tools like Nix to always have a valid lock file present at each published release to ensure reproducible builds.