consolidate ci and optimize build commands #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellioty
previously approved these changes
Sep 10, 2022
mitchmindtree
previously approved these changes
Sep 13, 2022
There was a problem hiding this comment.
I've no experience with cargo make but that comment is a big help! Interesting stuff, I knew there were issues with cargo's feature unification but didn't realise they were that bad. It'll be especially good to keep this in mind w.r.t. potential feature support in sway/forc.
Anyways, Lgtm!
Co-authored-by: mitchmindtree <mail@mitchellnordine.com>
Co-authored-by: mitchmindtree <mail@mitchellnordine.com>
ellioty
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our CI we had both
cargo make buildandcargo check --lockedwhich were doing basically the same things. This PR merges them together using a custom cargo make task. It also uses the cargo make gh action to avoid slower rust based caching.It also includes fuel-p2p in the normal test pipeline since there hasn't been any flakiness lately.