Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rust 1.64 #638

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Upgrade to rust 1.64 #638

merged 5 commits into from
Sep 23, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Sep 22, 2022 •
edited
Loading

  • clippy fixes

Attempted the following but was blocked by sagiegurari/cargo-make#712 and LukeMathWalker/cargo-chef#148:

  • use new workspace dependencies feature to consolidate version numbers for common deps
  • use common workspace package fields for versioning, licenses, etc

@Voxelot Voxelot requested a review from a team September 22, 2022 21:38
@ControlCplusControlV
Copy link
Contributor

Looks like CI bumps may also be necessary

@Voxelot
Copy link
Member Author

Voxelot commented Sep 22, 2022 •
edited
Loading

Running into the following problem: sagiegurari/cargo-make#712

@Voxelot
Copy link
Member Author

Voxelot commented Sep 22, 2022

Also blocked by LukeMathWalker/cargo-chef#148

going to revert all the workspace format changes until the ecosystem can catch up

@Voxelot Voxelot merged commit bcb86da into master Sep 23, 2022
@Voxelot Voxelot deleted the Voxelot/rust-1-64 branch September 23, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvrooman bvrooman bvrooman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Voxelot @ControlCplusControlV @bvrooman