Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix flake to generate contract abi bindings #665

Merged
merged 51 commits into from
Oct 10, 2022
Merged

Nix flake to generate contract abi bindings #665

merged 51 commits into from
Oct 10, 2022

Conversation

freesig
Copy link
Contributor

@freesig freesig commented Oct 3, 2022

No description provided.

@freesig freesig mentioned this pull request Oct 3, 2022
Voxelot
Voxelot previously approved these changes Oct 4, 2022
Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌🏻

@ControlCplusControlV
Copy link
Contributor

Hmmm, tx-gossiping tests seem to be running into some issue 🤔, don't think its related specifically to this PR but doing some investigating to see

Base automatically changed from relayer-mvp to master October 7, 2022 00:08
@freesig
Copy link
Contributor Author

freesig commented Oct 7, 2022

@Voxelot Can I get another review when you get a chance

Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tried replicating on a fresh install and ran into some issues so it would be nice to maybe expand this this in the future for first time users of nix rather than just experienced users.

From a fresh install I tried the commands and regularly ran into use '--extra-experimental-features nix-command and use '--extra-experimental-features flakes being required. Then a github permissions issue on fuel-v2-contracts (presumably because I haven't setup git with nix right)

@freesig
Copy link
Contributor Author

freesig commented Oct 9, 2022

LGTM, I tried replicating on a fresh install and ran into some issues so it would be nice to maybe expand this this in the future for first time users of nix rather than just experienced users.

From a fresh install I tried the commands and regularly ran into use '--extra-experimental-features nix-command and use '--extra-experimental-features flakes being required. Then a github permissions issue on fuel-v2-contracts (presumably because I haven't setup git with nix right)

Yeh I think the fuel-v2-contracts is because the repo is private so you need to have git ssh setup on your machine. I will open an issue to update the comments for this and the experimental features flag.

@freesig freesig merged commit 0794894 into master Oct 10, 2022
@freesig freesig deleted the relayer-mvp-nix branch October 10, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants