Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused types #689

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Remove unused types #689

merged 1 commit into from
Oct 11, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Oct 11, 2022

closes: #682

Remove a bunch of unused data types that no longer match up with our current spec or roadmap.

@Voxelot Voxelot requested review from freesig, xgreenx and a team October 11, 2022 02:31
freesig
freesig approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

ControlCplusControlV
ControlCplusControlV approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we have any CI checks for unused types??

@Voxelot
Copy link
Member Author

Voxelot commented Oct 11, 2022

LGTM, do we have any CI checks for unused types??

Cargo will already provide warnings for unused types that it can detect which block CI. However, if any of those types are marked pub, it's impossible for cargo to know whether the type is used or not.

@Voxelot Voxelot merged commit 4eb8da6 into master Oct 11, 2022
@Voxelot Voxelot deleted the Voxelot/relayer-cleanup branch October 11, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ControlCplusControlV ControlCplusControlV ControlCplusControlV approved these changes

@freesig freesig freesig approved these changes

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up unused data related to the old relayer
3 participants
@Voxelot @freesig @ControlCplusControlV