Enable withdrawals #691
Merged
Enable withdrawals #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freesig
force-pushed
the
freesig/enable-withdrawals
branch
from
3b38959 to
0df2081
Compare
ControlCplusControlV
previously requested changes
Oct 19, 2022
fuel-core/src/query.rs
Outdated
| use crate::tx_pool::TransactionStatus; | ||
|
|
||
| #[cfg(test)] | ||
| mod test; |
There was a problem hiding this comment.
Why does query have its own mod with a specific test file? I would rather unit tests be attached directly to the associated functions than breaking out into a test.rs
There was a problem hiding this comment.
Structurally it's basically the same as if the tests were in this file, since they need to be enclosed in a test module anyways. Personally, I prefer splitting modules into smaller files to reduce the amount of scrolling when working on something and make it easier to split related code across multiple windows.
There was a problem hiding this comment.
Yeh definitely a fan of breaking into a file. Keeping the tests inline only really works with very small tests.
Voxelot
reviewed
Oct 19, 2022
Voxelot
reviewed
Oct 19, 2022
Voxelot
reviewed
Oct 19, 2022
Voxelot
reviewed
Oct 21, 2022
Voxelot
reviewed
Oct 21, 2022
Voxelot
reviewed
Oct 21, 2022
Voxelot
reviewed
Oct 21, 2022
Voxelot
reviewed
Oct 24, 2022
Voxelot
reviewed
Oct 24, 2022
Voxelot
reviewed
Oct 24, 2022
…nable-withdrawals
Voxelot
reviewed
Oct 26, 2022
Voxelot
reviewed
Oct 26, 2022
Voxelot
reviewed
Oct 26, 2022
Voxelot
reviewed
Oct 26, 2022
Voxelot
approved these changes
Oct 26, 2022
MujkicA
pushed a commit
that referenced
this pull request
Oct 26, 2022
* building query * add merkle proof * Add root and proof set to OutputProof * added mocks * assert message id * added signature and block * finish integration test and wire up graph api * handle results * add comments * move to mod * fix bug Co-authored-by: Brandon Vrooman <brandon.vrooman@gmail.com> Co-authored-by: ControlCplusControlV <44706811+ControlCplusControlV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #567