Add gossipsub message validation #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
Oct 12, 2022
Voxelot
reviewed
Oct 12, 2022
Voxelot
reviewed
Oct 12, 2022
Voxelot
reviewed
Oct 12, 2022
Voxelot
reviewed
Oct 12, 2022
Voxelot
reviewed
Oct 12, 2022
Voxelot
reviewed
Oct 12, 2022
Voxelot
reviewed
Oct 12, 2022
Voxelot
reviewed
Oct 12, 2022
freesig
previously requested changes
Oct 17, 2022
Comment on lines
+107
to
+109
| pub trait NetworkData<T>: Debug + Send { | ||
| fn take_data(&mut self) -> Option<T>; | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub trait NetworkData<T>: Debug + Send { | |
| fn take_data(&mut self) -> Option<T>; | |
| } | |
| pub trait NetworkData<T>: Debug + Send { | |
| type Metadata; | |
| fn take_data(self) -> (Self::Metadata, T); | |
| } |
I'm thinking it would be better to actually split the type so that we don't have to handle the option?
There was a problem hiding this comment.
hmm maybe we can defer this to a followup task? Ideally in a way that wouldn't require users of this trait to know or care about the concrete type for metadata.
There was a problem hiding this comment.
I did raise this concern in the architecture PR but was told it was an implementation detail. Happy to do a follow up though
There was a problem hiding this comment.
yeah I think it's just a matter of having a fully fleshed out proposal of this actually working
Voxelot
previously approved these changes
Oct 18, 2022
…beak/gossipsub_validate_msg
Voxelot
approved these changes
Oct 19, 2022
MujkicA
pushed a commit
that referenced
this pull request
Oct 25, 2022
* remove loop from next_event * initial work * more work * trying to use an alternative approach to message id cache * quick break * fix sized issue * finalize gossipsub validation * remove unused * update fast_gossip_message_id * check MessageId calculation * cleanup network orchestrator * move types to p2p for reuse * add consensus gossip data instead * add serde only feature * update with suggestions * remove unused * use gossipsub_config * hash complete messages * use gossipsub config and its builder * import serde only as feature * use test-helpers from fuel-core-interfaces * to the right place in toml Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
MujkicA
pushed a commit
that referenced
this pull request
Oct 26, 2022
* remove loop from next_event * initial work * more work * trying to use an alternative approach to message id cache * quick break * fix sized issue * finalize gossipsub validation * remove unused * update fast_gossip_message_id * check MessageId calculation * cleanup network orchestrator * move types to p2p for reuse * add consensus gossip data instead * add serde only feature * update with suggestions * remove unused * use gossipsub_config * hash complete messages * use gossipsub config and its builder * import serde only as feature * use test-helpers from fuel-core-interfaces * to the right place in toml Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #679
In this PR we introduce message validation for our gossipsub messages.
The flow goes like this:
In this PR I have also removed unnecessary loop from p2p service's
next_event.