Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set eth block height on new blocks #698

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Set eth block height on new blocks #698

merged 4 commits into from
Oct 13, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Oct 13, 2022

The da_height header field was being set to default, which would prevent downloaded msgs from eth from being spent. This updates the currently used block generation method to always set the current relayer synced eth height.

Also added an integ test that downloaded messages from eth are spendable on fuel.

This is a bandaid solution until #677 is implemented.

@Voxelot Voxelot requested a review from a team October 13, 2022 21:43
Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda hard to tell what actually changed as it looks like most of the changes are just moving a function but looks fine to me.

Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually just noticed something

fuel-core/src/executor.rs Show resolved Hide resolved
@Voxelot Voxelot dismissed freesig’s stale review October 13, 2022 22:07

no applicable concern

@freesig freesig self-requested a review October 13, 2022 22:08
freesig
freesig previously approved these changes Oct 13, 2022
@Voxelot Voxelot enabled auto-merge (squash) October 13, 2022 22:44
@Voxelot Voxelot merged commit da0a38f into master Oct 13, 2022
@Voxelot Voxelot deleted the Voxelot/set_da_height branch October 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants