Create a BlockId type for safe conversion to Message #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
enhancement
Voxelot
reviewed
Oct 25, 2022
Voxelot
added a commit
that referenced
this pull request
Oct 26, 2022
* add block signing and db models for sealed blocks * add integ tests for checking sealed blocks * mock setting the block height after production * Create a BlockId type for safe conversion to Message (#719) * Create a BlockId type for safe conversion to Message * fmt * Clippy * Remove direct dep to fuel-crypto, as it's re-exported by fuel-vm * Allow Into impl for clippy * Fix lint name * replace [u8;32] with secret key & secret key wrapper * clippy * use derive_more for newtype traits * remove unneeded duplicate insert check * add as_message to block id & block_producer getter to consensus data * use real consensus data in the Interpreter::coinbase method * add error context * wean off of deref() Co-authored-by: Hannes Karppila <hannes.karppila@gmail.com>
MujkicA
pushed a commit
that referenced
this pull request
Oct 26, 2022
* add block signing and db models for sealed blocks * add integ tests for checking sealed blocks * mock setting the block height after production * Create a BlockId type for safe conversion to Message (#719) * Create a BlockId type for safe conversion to Message * fmt * Clippy * Remove direct dep to fuel-crypto, as it's re-exported by fuel-vm * Allow Into impl for clippy * Fix lint name * replace [u8;32] with secret key & secret key wrapper * clippy * use derive_more for newtype traits * remove unneeded duplicate insert check * add as_message to block id & block_producer getter to consensus data * use real consensus data in the Interpreter::coinbase method * add error context * wean off of deref() Co-authored-by: Hannes Karppila <hannes.karppila@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to find the right boundary for the newtype. It cannot be created like types in the fuel-types crate, since the construction shouldn't be public. This is the minimal amount of changes to introduce the type, and it's converted to Bytes32 for interoperating with database and GraphQL functions. It might make sense to switch the database to use the BlockId type as well.
Requested in #718