fix bug where txs wouldn't get squeezed if coin state already existed #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
previously approved these changes
Nov 9, 2022
xgreenx
previously requested changes
Nov 9, 2022
xgreenx
dismissed
their stale review
I'm wrong, if there is not is_spend_by, we should become him
xgreenx
reviewed
Nov 9, 2022
Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
|
looks like the tests are passing now, ty for the assist @xgreenx |
freesig
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug where submitting more than two txs that conflict on the same input would stop squeezing the lower priced txs after the first squeeze.
This would ultimately lead to the tx with the lower price getting skipped by the executor, making this only a minor annoyance. However it causes wasted computation during block production.