Add GlobalCfg, cli vm-backtrace option #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
Nov 29, 2021
Voxelot
reviewed
Nov 30, 2021
Voxelot
reviewed
Dec 1, 2021
rakita
force-pushed
the
rakita/backtrace
branch
from
e4af185 to
db48aad
Compare
|
#81 will fix these new errors that started appearing due to Rust 1.57 |
rakita
force-pushed
the
rakita/backtrace
branch
2 times, most recently
from
8389d8b to
804a454
Compare
3 tasks
Voxelot
reviewed
Dec 4, 2021
Voxelot
approved these changes
Dec 4, 2021
|
Just realized this PR is likely blocked on FuelLabs/fuel-vm#47 since it will change the way backtraces are enabled in the vm. |
Then lets us leave this unmerged and we will rebase after vm pull request is complete. |
|
@rakita this is no longer blocked on FuelLabs/fuel-vm#47 btw |
Voxelot
requested changes
Dec 24, 2021
rakita
force-pushed
the
rakita/backtrace
branch
from
d8dce1c to
33a6129
Compare
rakita
commented
Jan 3, 2022
rakita
force-pushed
the
rakita/backtrace
branch
from
953f3f9 to
a50b916
Compare
Voxelot
reviewed
Jan 24, 2022
Voxelot
reviewed
Jan 24, 2022
Voxelot
approved these changes
Jan 26, 2022
ControlCplusControlV
pushed a commit
that referenced
this pull request
Jan 15, 2023
* Data driven test framework * Impl ToString for Test to generate test names * revert unrelated change * Stable * Format * Data test stable * undo change to smt * Use `?` instead of `unwrap` * Reorder dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dont print memory from backtrace because it is 4mb in size. There is the possibility to compress it and print it in that way, but maybe this is task for another time.
For compression I mean something like:
FirstFlag | NumOfZeroes | NumOfData | data | NumOfZeroes | NumOfData | Datathis compression will give us a lot smaller size of memory assuming a lot of it is zeroed. This can be printed differently but all data would be here.