Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file and line into KvStoreError::NotFound to simplify debugging #790

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Nov 25, 2022

It will help in cases like this.

@xgreenx xgreenx requested a review from a team November 25, 2022 18:29
@xgreenx xgreenx self-assigned this Nov 25, 2022
Added a separate macro for `NotFound` error generation.
@@ -95,9 +95,9 @@ jobs:
- command: make
args: check --locked
- command: test
args: --tests --all-features --workspace
args: --all-features --workspace
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enables running of tests for documentation too

@xgreenx xgreenx merged commit 5af07b2 into master Nov 28, 2022
@xgreenx xgreenx deleted the feature/add-metadata-for-not-found branch November 28, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants