Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused crates #805

Merged
merged 9 commits into from
Nov 30, 2022
Merged

remove unused crates #805

merged 9 commits into from
Nov 30, 2022

Conversation

freesig
Copy link
Contributor

@freesig freesig commented Nov 30, 2022

No description provided.

@freesig freesig changed the title Freesig/remove unused crates remove unused crates Nov 30, 2022
@@ -19,7 +19,6 @@ fuel-poa-coordinator = { path = "../fuel-poa-coordinator", version = "0.14.1" }
hex = { version = "0.4", features = ["serde"] }
itertools = "0.10"
rand = "0.8"
ron = "0.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk how this even got here 😅

@Voxelot
Copy link
Member

Voxelot commented Nov 30, 2022

yay less dep hell

@freesig freesig enabled auto-merge (squash) November 30, 2022 01:41
@freesig freesig merged commit 4870283 into master Nov 30, 2022
@freesig freesig deleted the freesig/remove-unused-crates branch November 30, 2022 01:47
@ControlCplusControlV
Copy link
Contributor

ControlCplusControlV commented Nov 30, 2022

Is there not a CI job we could make to check for unused deps? Using something in the line of unused-deps

@deekerno
Copy link
Contributor

deekerno commented Dec 2, 2022

Is there not a CI job we could make to check for unused deps? Using something in the line of unused-deps

On the indexer, we use the following:

      - name: Check Unused Deps
        uses: actions-rs/cargo@v1
        with:
          command: udeps
          args: --locked --all-targets --all-features

It does require nightly though.

@ControlCplusControlV
Copy link
Contributor

We used to use nightly for format so this might be worth trying to see, since IIRC you can use nightly toolchain for just the tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants