Move block producer requirements into corresponding crates #814
Conversation
Reused patter of adapter in the `fuel-core`.
fuel-poa-coordinator/src/service.rs
Outdated
| @@ -56,6 +59,24 @@ use tracing::{ | |||
| warn, | |||
| }; | |||
|
|
|||
| #[async_trait::async_trait] | |||
| pub trait BlockProducer: Send + Sync { | |||
| // TODO: Right now production and execution of the block is one step, but in the future, | |||
There was a problem hiding this comment.
Since we are refactoring right now, would it be worth considering building out this code path right now to make it easier for future milestones. produce_and_execute_block is relatively simple and we could make a produce function which returns a block, then just call an execute function right away, which preserves functionality but avoids a future breaking interface change on the BlockProducer
There was a problem hiding this comment.
It is not refactoring mentioned in the #809. It is simply moving from one place to another to unblock the development for me and don't create a mess in one PR=)
The comment describes the problem bad=) We can't produce the block without the execution of transactions(otherwise, it is a useless block). The comment was meant to be, "The current code produces, executes, and commits the block. But it should only produce and execute".
It is that I'm trying to fix=) This "refactoring" for this change. But without #812 it looks ugly.
ControlCplusControlV
added
breaking
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| pub trait Relayer: Sync + Send { |
There was a problem hiding this comment.
could we move this to a ports module? Just so we have a consistent pattern for locating these kinds of external dep interfaces within each crate.
fuel-core/src/service/modules.rs
Outdated
| @@ -301,3 +305,31 @@ impl BlockProducerRelayer for MaybeRelayerAdapter { | |||
| .unwrap_or_default()) | |||
| } | |||
| } | |||
|
|
|||
| struct PoACoordinatorAdapter { | |||
There was a problem hiding this comment.
Could we move this to an adapters module, e.g. similar to this path? https://github.com/FuelLabs/fuel-core/blob/master/docs/architecture.md#adapters-fuel_coreserviceadapterspoa_consensus
fuel-poa-coordinator/src/service.rs
Outdated
| @@ -56,6 +59,24 @@ use tracing::{ | |||
| warn, | |||
| }; | |||
|
|
|||
| #[async_trait::async_trait] | |||
| pub trait BlockProducer: Send + Sync { | |||
There was a problem hiding this comment.
[nit] consider moving to a crate-root ports module
I reused the pattern of the adapter for the
block-producerand moved block-producer requirements into corresponding crates.It is part of the change to return an
ExecutionResultwith a database transaction inside. The rest of the change will be in a separate PR.