State Read/Write/Clear range implementation #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
ghost
self-assigned this
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
|
Moved to draft, as the PR isn't ready for review |
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
ghost
marked this pull request as ready for review
ghost
marked this pull request as draft
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
ghost
marked this pull request as ready for review
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Dentosal
reviewed
Dec 12, 2022
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
Voxelot
reviewed
Dec 12, 2022
xgreenx
reviewed
Dec 13, 2022
| } | ||
|
|
||
| #[test] | ||
| fn insert_single_unset() { |
There was a problem hiding this comment.
Almost all test below are similar and depends on input arguments. Could you reuse test-case library and make them more compact, please? We already use it in many places, and you can use them as examples
freesig
reviewed
Dec 13, 2022
* Simplified the code of range operations * Simplified tests
Signed-off-by: Mitch Martin <mitch.martin@fuel.sh>
…FuelLabs/fuel-core into mitch-fuel/rwc-range-from-to-state Signed-off-by: Mitch Martin <mitch.martin@fuel.sh> # Conflicts: # fuel-core/src/database/vm_database.rs
…abs/fuel-core into mitch-fuel/rwc-range-from-to-state
…abs/fuel-core into mitch-fuel/rwc-range-from-to-state
Voxelot
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mitch Martin mitch.martin@fuel.sh