Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify naming of services and tasks #870

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Unify naming of services and tasks #870

merged 1 commit into from
Dec 23, 2022

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Dec 23, 2022

  • Renamed all runnable parts of the service into Task.
  • Renamed each file that contains the runnable part into service.rs.
  • Removed fuel_core_txpool::ServiceBuilder.
  • Removed fuel_core_importer and fuel_core_sync from fuel-core.
  • Renamed NetworkOrchestrator into Task.
  • All services expect DB without Arc or Box.

@xgreenx
Renamed all runnable part of the service into Task.
21bfe94 
Renamed each file that contains runnable part into `service.rs`.
Removed `fuel_core_txpool::ServiceBuilder`.
Removed `fuel_core_importer` and `fuel_core_sync` from `fuel-core`.
Renamed `NetworkOrchestrator` into `Task`.
All services expect `DB` without `Arc` or `Box`.
@xgreenx xgreenx requested a review from a team December 23, 2022 19:57
@xgreenx xgreenx self-assigned this Dec 23, 2022
@xgreenx xgreenx merged commit bd3f691 into master Dec 23, 2022
@xgreenx xgreenx deleted the feature/unify-naming-for-services branch December 23, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voxelot Voxelot Voxelot approved these changes

Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xgreenx @Voxelot