-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect the block importer with outside world #915
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
393b5a7
- Added the main logic of the block importer.
xgreenx a6d835e
Tested `commit_result`
xgreenx 0b71b7f
Make clippy happy
xgreenx d7d7a6c
Added tests for `verify_and_execute_block` part of the importer
xgreenx d60971a
Added test for lock for `verify_and_execute_block`
xgreenx aa720f3
Update crates/services/importer/src/importer.rs
xgreenx 7e3ba96
Make fmt happy
xgreenx 3be7239
Added verifeir for the block
xgreenx f90e026
Fixed merge conflicts
xgreenx 7d21d6b
Fix test to use Validator role
xgreenx d9cade3
add unit tests to verify genesis
freesig d67e729
add unit tests to verify poa block
freesig 5a16bc0
Linked TODO to the issue
xgreenx 838a716
Added one more test for geensis
xgreenx e7e1835
- Removed `CHAIN_HEIGHT_KEY`, because now we have a genesis block to …
xgreenx 637f02e
Checked that there are no panic.
xgreenx ab8c5fd
Fix compilation error
xgreenx 016a389
test manual block production
freesig 42c890e
check workspace
freesig 4f1e02d
had flag around the wrong way
freesig 27020e1
Renamed generics.
xgreenx 950fb3c
Merge branch 'feature/block-importer' into featue/block-verifier
xgreenx 6b9065f
Merge branch 'featue/block-verifier' into featue/connect-block-importer
xgreenx fa14327
Remvoe TODO
xgreenx 21cc173
Merge branch 'master' into featue/block-verifier
xgreenx 85c6707
Merge branch 'featue/block-verifier' into featue/connect-block-importer
xgreenx c2913b9
Removed `BlockProduction` from `ChainConfig`.
xgreenx 21cf872
Merge branch 'master' into featue/block-verifier
xgreenx a0ef9a3
Replace `poa_config` with `into`
xgreenx a195c56
Push new snapshots
xgreenx cb30cd8
Applied suggestions from the PR
xgreenx 8de4be2
Merge branch 'featue/block-verifier' into featue/connect-block-importer
xgreenx 872d461
Merge with verifier
xgreenx 3966ad3
Removed "humantime-serde"
xgreenx 028627e
Merge branch 'featue/block-verifier' into featue/connect-block-importer
ControlCplusControlV f692b3d
upgrade clap in fuel-core cli, improve cli interface for consensus args
Voxelot eda254e
fix lockfile
Voxelot 13bab2c
cargo lint
Voxelot 457102f
add readme instructions for disabling block production
Voxelot 9552a24
Merge branch 'featue/block-verifier' into featue/connect-block-importer
xgreenx 11f9f6d
Make clippy happy
xgreenx 09dfafe
Merge branch 'featue/block-verifier' into featue/connect-block-importer
xgreenx f687d69
Merge branch 'master' into featue/connect-block-importer
Voxelot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything caught by this that isn't already caught?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep it catches running
cargo check --all-targets
at the workspace root which nothing else does. It has a different feature set theall-features
or running the command at each crate level like the make command does.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I guess we can remove it, because
cargo test --all-features --workspace
do the same)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer to remove it then since CI times are already pretty long