request response for get transactions & sealed header from p2p network #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freesig
changed the base branch from
master
to
leviathanbeak/heartbeat_protocol
freesig
reviewed
Jan 20, 2023
# Conflicts: # crates/types/src/services/p2p.rs
Use `PeerId`
Fixed unit test with deadlock.
Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
…t_transactions_from_peer
…beak/heartbeat_protocol
…t_transactions_from_peer
leviathanbeak
changed the title
|
Note: the PR is not that big, it contains small refactors and better naming apart from the needed changes |
…:FuelLabs/fuel-core into leviathanbeak/get_transactions_from_peer
Co-authored-by: ControlCplusControlV <44706811+ControlCplusControlV@users.noreply.github.com>
freesig
suggested changes
Jan 23, 2023
| @@ -1275,7 +1287,7 @@ mod tests { | |||
| tokio::select! { | |||
| message_sent = rx_test_end.recv() => { | |||
| // we received a signal to end the test | |||
| assert_eq!(message_sent, Some(true), "Received wrong block height!"); | |||
| assert_eq!(message_sent, Some(true), "Receuved incorrect or missing missing messsage"); | |||
There was a problem hiding this comment.
[nit]
Suggested change
| assert_eq!(message_sent, Some(true), "Receuved incorrect or missing missing messsage"); | |
| assert_eq!(message_sent, Some(true), "Received incorrect or missing missing messsage"); |
Assertion seems to be failing here, although it make sense with p2p being disabled that p2p failed
There was a problem hiding this comment.
there is something wrong with Request::Transactions test others are passing, if no one solves it by tomorrow I will try it.
It seems the request doesn't even go through, the node gets disconnected every time I re-ran it with Transactions, other requests pass which is (slightly) weird
freesig
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #878 #877
The work has been done on 2 (now merged) branches, by @freesig and myself.