Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return back the "Output Bech32Address for initial accounts" change. #921

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Jan 20, 2023

This change was done at the same time as moving this file into another place, so during conflict resolution, we missed it.

Closes #593

#594

This change was done at teh same time with moving of this file into another place, so during conflicts resolving we missed it.
@xgreenx xgreenx requested review from kayagokalp and a team January 20, 2023 13:10
@xgreenx xgreenx self-assigned this Jan 20, 2023
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@ControlCplusControlV ControlCplusControlV added the enhancement New feature or request label Jan 20, 2023
Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with cargo run -- run --db-type in-memory bech32 is outputted as expected, LGTM

2023-01-20T16:30:44.306985Z  INFO fuel_core_chain_config::config::chain: 86: PrivateKey(0x862512a2363db2b3a375c0d4bbbd27172180d89f23f2e259bac850ab02619301), Address(0xe10f526b192593793b7a1559a391445faba82a1d669e3eb2dcd17f9c121b24b1 [bech32: fuel1uy84y6ceykfhjwm6z4v68y2yt746s2sav60ravku69lecysmyjcss0yrdx]), Balance(10000000)
2023-01-20T16:30:44.307284Z  INFO fuel_core_chain_config::config::chain: 86:

@xgreenx xgreenx merged commit 5350b8b into master Jan 20, 2023
@xgreenx xgreenx deleted the feature/print-bech32-address branch January 20, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants