Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.67 and FIx Clippy Lints #963

Merged
merged 5 commits into from
Jan 30, 2023

Conversation

ControlCplusControlV
Copy link
Contributor

No description provided.

@ControlCplusControlV ControlCplusControlV added the enhancement New feature or request label Jan 28, 2023
@ControlCplusControlV ControlCplusControlV requested a review from a team January 28, 2023 19:58
@ControlCplusControlV ControlCplusControlV self-assigned this Jan 28, 2023
@ControlCplusControlV
Copy link
Contributor Author

Mainly thinking of updating so soon because of the fuel-vm pr to use new stabilized std lib function, so would be good to ensure everything is on the same version

Copy link
Contributor

@leviathanbeak leviathanbeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy ftw

@ControlCplusControlV
Copy link
Contributor Author

Do we need another review before merge? I know updating rust versions can sometimes break things so a bit hesitant to merge but if its fine I can

Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to merge

@ControlCplusControlV ControlCplusControlV merged commit 4f09fd1 into master Jan 30, 2023
@ControlCplusControlV ControlCplusControlV deleted the controlc/clippy branch January 30, 2023 01:00
@Voxelot
Copy link
Member

Voxelot commented Jan 30, 2023

We should also update the rust version in our docker image build as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants