Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements during work with the database #976

Merged
merged 6 commits into from
Feb 3, 2023
Merged

Some improvements during work with the database #976

merged 6 commits into from
Feb 3, 2023

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Feb 3, 2023 •
edited
Loading

Closes #622

Each point of the issue is made as a separate commit, so it may be simpler to review each commit.

@xgreenx
Optimized iteration with prefix.
4b541c8 
Removed cloning of keys and values during iteration of the RocksDB storage.
@xgreenx
Used Option<&[u8]> instead of the Option<Vec<u8>>
9ecf838
@xgreenx
Accept value by reference in the Database::insert
1d36f26
@xgreenx
Renamed exist into contains_key.
36cb4e9 
Renamed internal methods with `_` prefix.
@xgreenx xgreenx changed the title Feature/some improvments for database Some improvements during work with the database Feb 3, 2023
@xgreenx xgreenx self-assigned this Feb 3, 2023
@xgreenx xgreenx requested a review from a team February 3, 2023 02:14
@xgreenx xgreenx marked this pull request as ready for review February 3, 2023 02:14
@xgreenx xgreenx mentioned this pull request Feb 3, 2023
Closed
freesig
freesig previously requested changes Feb 3, 2023
View reviewed changes
crates/fuel-core/src/database.rs Outdated Show resolved Hide resolved
@xgreenx xgreenx requested review from freesig and Voxelot February 3, 2023 09:19
Voxelot
Voxelot approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, will be interesting to see how much this improves perf by re-benchmarking after we get through the rest of these todos

@Voxelot Voxelot dismissed freesig’s stale review February 3, 2023 19:32

requested changes were addresses

@xgreenx xgreenx merged commit d323c6f into master Feb 3, 2023
@xgreenx xgreenx deleted the feature/some-improvments-for-database branch February 3, 2023 19:42
@xgreenx xgreenx mentioned this pull request Feb 13, 2023
Merged
@Voxelot Voxelot mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voxelot Voxelot Voxelot approved these changes

@freesig freesig Awaiting requested review from freesig

Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some improvements during work with the database
3 participants
@xgreenx @Voxelot @freesig