Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace usage of futures-timer to avoid extra helper threads #982

Merged
merged 1 commit into from
Feb 4, 2023
Merged

replace usage of futures-timer to avoid extra helper threads #982

merged 1 commit into from
Feb 4, 2023

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Feb 3, 2023

futures-timer was being used in p2p, however it makes use of helper threads which are unnecessary since we use a tokio runtime.

@Voxelot Voxelot requested a review from a team February 3, 2023 23:34
@Voxelot Voxelot enabled auto-merge (squash) February 4, 2023 00:03
@Voxelot Voxelot requested a review from leviathanbeak February 4, 2023 00:03
bvrooman
bvrooman approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@bvrooman bvrooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Were you able to manually verify that there were the expected number of threads now?

@Voxelot Voxelot merged commit da4ae8a into master Feb 4, 2023
@Voxelot Voxelot deleted the Voxelot/remove-futures-timer branch February 4, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvrooman bvrooman bvrooman approved these changes

@leviathanbeak leviathanbeak Awaiting requested review from leviathanbeak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Voxelot @bvrooman