Avoid feature unification during testing of --no-default-features #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm this is too slow (which is probably why we didn't do it before). Will investigate how we can speed this up. |
freesig
suggested changes
Feb 6, 2023
freesig
previously approved these changes
Feb 6, 2023
freesig
previously approved these changes
Feb 7, 2023
|
Still pretty slow after fixing the --workspace flag. Takes 30m to build and test each crate individually. Might be worth doing the slowest crates in a parallel job. |
freesig
approved these changes
Feb 7, 2023
|
looks like after warming up the cache, the build time is now the same as the normal test job with all features enabled. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our --no-default-features testing wasn't working as expected due to feature unification. This change ensures each crate is tested in isolation with no extra features enabled.