Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sub-unit gas prices #342

Closed
adlerjohn opened this issue Jun 9, 2022 · 1 comment · Fixed by #343 or FuelLabs/fuel-vm#148
Closed

Allow sub-unit gas prices #342

adlerjohn opened this issue Jun 9, 2022 · 1 comment · Fixed by #343 or FuelLabs/fuel-vm#148
Assignees
@adlerjohn
Labels
comp:FVM Component: FuelVM comp:VAL Component: Transaction Validity outside the Fuel VM

Comments

@adlerjohn
Copy link
Contributor

Rather than specifying gas prices in units of the base asset, specify them in some factor of units of the base asset, e.g. 1/1,000,000,000th of a unit. Then, when doing final gas accounting, round up to the nearest unit.

This will allow for much cheaper transactions, as otherwise even with a 1 unit gas price, transactions might still consume quite a bit of the base asset.
@adlerjohn adlerjohn added comp:FVM Component: FuelVM comp:VAL Component: Transaction Validity outside the Fuel VM labels Jun 9, 2022
@adlerjohn adlerjohn self-assigned this Jun 9, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network Jun 9, 2022
@adlerjohn adlerjohn mentioned this issue Jun 9, 2022
Merged
3 tasks
@vlopes11
Copy link
Contributor

Recommended steps to implement:

  • Implement the constant as consensus parameter in fuel-tx
  • Perform the conversion in transaction initialization/post-execution in fuel-vm

vlopes11 added a commit to FuelLabs/fuel-tx that referenced this issue Jun 10, 2022
@vlopes11
Add gas price factor consensus parameter
8daa90c 
The gas price factor will be used to convert between gas units and the
base asset value of the transaction.

This will empower the users to execute cheap/micro transactions without
being punished with high gas overheads.

Related issue: FuelLabs/fuel-specs#342
@vlopes11 vlopes11 mentioned this issue Jun 10, 2022
Merged
vlopes11 added a commit to FuelLabs/fuel-tx that referenced this issue Jun 10, 2022
@vlopes11
Add gas price factor consensus parameter
c27f896 
The gas price factor will be used to convert between gas units and the
base asset value of the transaction.

This will empower the users to execute cheap/micro transactions without
being punished with high gas overheads.

Related issue: FuelLabs/fuel-specs#342
vlopes11 added a commit to FuelLabs/fuel-tx that referenced this issue Jun 10, 2022
@vlopes11
Add gas price factor consensus parameter
1957b8c 
The gas price factor will be used to convert between gas units and the
base asset value of the transaction.

This will empower the users to execute cheap/micro transactions without
being punished with high gas overheads.

Related issue: FuelLabs/fuel-specs#342
Repository owner moved this from Todo to Done in Fuel Network Jun 10, 2022
vlopes11 added a commit to FuelLabs/fuel-tx that referenced this issue Jun 10, 2022
@vlopes11
Add gas price factor consensus parameter (#141)
ed8d3ef 
The gas price factor will be used to convert between gas units and the
base asset value of the transaction.

This will empower the users to execute cheap/micro transactions without
being punished with high gas overheads.

Related issue: FuelLabs/fuel-specs#342
vlopes11 added a commit to FuelLabs/fuel-vm that referenced this issue Jun 13, 2022
@vlopes11
Add gas factor to gas cost and refund calculation
91b0981 
Related issue: FuelLabs/fuel-tx#141
Closes FuelLabs/fuel-specs#342
vlopes11 added a commit to FuelLabs/fuel-vm that referenced this issue Jun 13, 2022
@vlopes11
Add gas factor to gas cost and refund calculation
2b7c2e8 
Related issue: FuelLabs/fuel-tx#141
Closes FuelLabs/fuel-specs#342
@vlopes11 vlopes11 mentioned this issue Jun 13, 2022
Merged
vlopes11 added a commit to FuelLabs/fuel-vm that referenced this issue Jun 13, 2022
@vlopes11
Add gas factor to gas cost and refund calculation
72dbdcf 
Related issue: FuelLabs/fuel-tx#141
Closes FuelLabs/fuel-specs#342
vlopes11 added a commit to FuelLabs/fuel-vm that referenced this issue Jun 14, 2022
@vlopes11
Add gas factor to gas cost and refund calculation (#148)
19398e5 
Related issue: FuelLabs/fuel-tx#141
Closes FuelLabs/fuel-specs#342
ControlCplusControlV pushed a commit to FuelLabs/fuel-vm that referenced this issue Dec 1, 2022
@vlopes11
Add gas price factor consensus parameter (#141)
b3d5374 
The gas price factor will be used to convert between gas units and the
base asset value of the transaction.

This will empower the users to execute cheap/micro transactions without
being punished with high gas overheads.

Related issue: FuelLabs/fuel-specs#342
xgreenx pushed a commit to FuelLabs/fuel-vm that referenced this issue Dec 20, 2022
@vlopes11 @xgreenx
Add gas price factor consensus parameter (#141)
93d6f4b 
The gas price factor will be used to convert between gas units and the
base asset value of the transaction.

This will empower the users to execute cheap/micro transactions without
being punished with high gas overheads.

Related issue: FuelLabs/fuel-specs#342
xgreenx pushed a commit to FuelLabs/fuel-vm that referenced this issue Dec 20, 2022
@vlopes11 @xgreenx
Add gas price factor consensus parameter (#141)
05411f6 
The gas price factor will be used to convert between gas units and the
base asset value of the transaction.

This will empower the users to execute cheap/micro transactions without
being punished with high gas overheads.

Related issue: FuelLabs/fuel-specs#342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adlerjohn adlerjohn

Labels
comp:FVM Component: FuelVM comp:VAL Component: Transaction Validity outside the Fuel VM
Projects
Fuel Network
Archived in project
Milestone
No milestone
2 participants
@adlerjohn @vlopes11