Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formalize Double-spend Validation #383

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Formalize Double-spend Validation #383

merged 1 commit into from
Jul 4, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Jul 1, 2022

We already implemented these checks, but they are missing from the specs.

@Voxelot
Formalize Double-spend Validation
bc5a1bf 
We already implemented these checks, but they are missing from the specs.
@Voxelot Voxelot requested a review from adlerjohn July 1, 2022 22:02
@Voxelot Voxelot self-assigned this Jul 1, 2022
@Voxelot Voxelot requested review from vlopes11 and pixelcircuits July 1, 2022 22:02
@pixelcircuits
Copy link
Contributor

Do we also need to specify the validity of the amount on InputCoin and amount/sender/recipient/data on InputMessage?

@Voxelot
Copy link
Member Author

Voxelot commented Jul 2, 2022

Most likely, although that would be separate from tx format validation and requires interaction with state.

@adlerjohn adlerjohn added the comp:VAL Component: Transaction Validity outside the Fuel VM label Jul 2, 2022
vlopes11
vlopes11 approved these changes Jul 3, 2022
View reviewed changes
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As a nit, it might be worthy to use the same terminology both in the code and in the specs.

In the code, for instance, it is named as "asset id" and "utxo id".

https://github.com/FuelLabs/fuel-tx/blob/aacd5624a98242f474c1989b131a3a4771b61ba4/src/transaction/validation.rs#L252-L260

@adlerjohn adlerjohn merged commit 089f450 into master Jul 4, 2022
@adlerjohn adlerjohn deleted the Voxelot/double-spend branch July 4, 2022 23:36
@Voxelot Voxelot mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelcircuits pixelcircuits pixelcircuits approved these changes

@vlopes11 vlopes11 vlopes11 approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

Assignees

@Voxelot Voxelot

Labels
comp:VAL Component: Transaction Validity outside the Fuel VM
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Voxelot @pixelcircuits @adlerjohn @vlopes11