Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the ABI spec with the new JSON ABI format #416

Merged
merged 11 commits into from
Oct 20, 2022
Merged

Update the ABI spec with the new JSON ABI format #416

merged 11 commits into from
Oct 20, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Oct 13, 2022 •
edited
Loading

Closes #401
Closes #375
Closes #323

Summary:

  • Update the ABI spec with the new JSON ABI format that supports generics (including changing outputs to a single output).
  • Describe loggedTypes.

Tasks:

  • Update the section that describes each property
  • Update the sections with all the types
  • Update the complex example
  • Include an example that uses logs

@mohammadfawaz mohammadfawaz self-assigned this Oct 13, 2022
@mohammadfawaz mohammadfawaz added the ABI Contract ABI label Oct 13, 2022
@mohammadfawaz mohammadfawaz force-pushed the mohammadfawaz/new_abi_spec branch 2 times, most recently from d09b000 to 0896a24 Compare October 13, 2022 03:01
@mohammadfawaz mohammadfawaz force-pushed the mohammadfawaz/new_abi_spec branch from 0896a24 to 06bb2ff Compare October 13, 2022 03:02
@mohammadfawaz mohammadfawaz force-pushed the mohammadfawaz/new_abi_spec branch from 73864c0 to 2d941c9 Compare October 13, 2022 03:04
@mohammadfawaz mohammadfawaz marked this pull request as ready for review October 14, 2022 16:21
@mohammadfawaz mohammadfawaz requested review from adlerjohn and a team October 14, 2022 16:21
sezna
sezna approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but @digorithm should take a look before this goes in

@digorithm
Copy link
Member

Taking another look now 👀

digorithm
digorithm approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice; thanks for doing this, @mohammadfawaz!

@mohammadfawaz mohammadfawaz mentioned this pull request Oct 15, 2022
Merged
@mohammadfawaz mohammadfawaz merged commit 60c9f1b into master Oct 20, 2022
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/new_abi_spec branch October 20, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezna sezna sezna approved these changes

@digorithm digorithm digorithm approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees

@mohammadfawaz mohammadfawaz

Labels
ABI Contract ABI
Projects
None yet
Milestone
No milestone
3 participants
@mohammadfawaz @digorithm @sezna