Encoding version 1 documentation #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digorithm
previously requested changes
Jan 18, 2024
There was a problem hiding this comment.
Thanks for doing this. I suggested a few changes to keep the consistency with the rest of the specs.
Also, I'd suggest prefacing/opening the Version 1 header with an explanation that it's an upgrade that will replace the original version, described above.
Maybe, in the future, once this is fully settled, we should delete the previous spec (the one above version 1).
xunilrj
dismissed
digorithm’s stale review
Changes were already incorporated.
IGI-111
reviewed
Jan 19, 2024
3 tasks
danielbate
reviewed
Jan 23, 2024
digorithm
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the first version of the documentation of the new encoding version 1.