Clarify that non-zero reserved part of an instruction causes vm panic #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Dentosal
changed the title
bvrooman
approved these changes
May 23, 2024
xgreenx
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM PR: FuelLabs/fuel-vm#737
What is says on the tin. This is a small but breaking change. It's unlikely to cause any breakage, as no Sway code or code constructed using the fuel-asm helper functions is affected.
This change is originating from an audit report that pointed out the likely unintentional behavior of the unused part of instruction is ignored.
Before requesting review