Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing type argument name from ABI spec #620

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Add missing type argument name from ABI spec #620

merged 1 commit into from
Dec 6, 2024

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Dec 5, 2024 •
edited
Loading

In the ABI spec, a typeArgument is missing the name property, as shown here.

Before requesting review

  • I have reviewed the code myself

After merging, notify other teams

[Add or remove entries as needed]

@danielbate danielbate added the ABI Contract ABI label Dec 5, 2024
@danielbate danielbate self-assigned this Dec 5, 2024
@danielbate danielbate marked this pull request as ready for review December 5, 2024 14:51
@petertonysmith94 petertonysmith94 mentioned this pull request Dec 5, 2024
Open
4 tasks
@danielbate danielbate merged commit cebd4c5 into master Dec 6, 2024
6 checks passed
@danielbate danielbate deleted the db/chore/missing-abi-spec-property branch December 6, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@esdrubal esdrubal esdrubal approved these changes

@arboleya arboleya arboleya approved these changes

@nedsalk nedsalk Awaiting requested review from nedsalk

Assignees

@danielbate danielbate

Labels
ABI Contract ABI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbate @arboleya @esdrubal @petertonysmith94