This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Changed the Nonce to be uint256
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## code-freeze-beta4 #35 +/- ##
=====================================================
Coverage ? 100.00%
=====================================================
Files ? 7
Lines ? 139
Branches ? 40
=====================================================
Hits ? 139
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pixelcircuits
approved these changes
Mar 21, 2023
xgreenx
added a commit
to FuelLabs/fuel-core
that referenced
this pull request
Mar 22, 2023
Fixes #946 This PR also uses the latest `fuel-vm` with FuelLabs/fuel-vm#373. - Updated the code to use named input types. - Removed the usage of the `MessageId` from all places except the `BlockHeader` and related to the block stuff. - Used `Nonce` as a primary key for messages instead of `MessageId`. Because of it, we don't need `CheckedMessage` anymore. Also, several tests failed because the nonce was the same. - Updated the `Nonce` from `u64` to 32 bytes. Updated the ABI to use `uint256` instead of `uint64` - FuelLabs/fuel-v2-contracts#35 - Renamed `Resources` into `Coins`. Renamed all comments and GraphQL API. Moved `coin.rs` and `resource.rs` into one `coins.rs`. - Fixed some tests for FuelLabs/fuel-vm#377 not to increase the `HP`. - Removed usage of the `Output::Message`. - Renamed `message_output_count` - > `message_receipt_count` and `message_output_root` -> `message_receipt_root` And the main feature of why this change was created(implemented by several lines): `MessageData` aren't marked as spent unless included in a successfully executed script tx --------- Co-authored-by: Voxelot <brandonkite92@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is code freeze, so I'm not sure where we need to merge it=) I created it not to forget because
fuel-coreexpects that after FuelLabs/fuel-core#1052