Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parameter to define base asset ID #164

Closed
vlopes11 opened this issue Jul 4, 2022 · 1 comment · Fixed by FuelLabs/fuel-core#1339
Closed

Use parameter to define base asset ID #164

vlopes11 opened this issue Jul 4, 2022 · 1 comment · Fixed by FuelLabs/fuel-core#1339
Assignees
@bvrooman
Labels
fuel-vm Related to the `fuel-vm` crate.

Comments

@vlopes11
Copy link
Contributor

vlopes11 commented Jul 4, 2022

Orthogonal to this PR, but I'm thinking the base asset's ID should be a parameter in the VM. It's not necessarily guaranteed to be AssetId::default() always. Both the specs and the implementation should be modular in this regard. Can you file an issue to track changing?

Originally posted by @adlerjohn in #159 (comment)
@Voxelot
Copy link
Member

Voxelot commented Jul 14, 2022

I think this should be added to the ConsensusParams Struct in fuel-tx

@Voxelot Voxelot moved this to Todo in Fuel Network Aug 2, 2022
@mitchmindtree mitchmindtree added the fuel-vm Related to the `fuel-vm` crate. label Dec 9, 2022
@xgreenx xgreenx mentioned this issue Jun 13, 2023
Open
This was referenced Aug 31, 2023
Merged
Merged
@sdankel sdankel removed this from Fuel Network Sep 5, 2023
bvrooman pushed a commit to FuelLabs/fuel-core that referenced this issue Sep 13, 2023
feat: Configurable base asset (#1339)
a539bb9 
Related issues:
- Closes FuelLabs/fuel-vm#164
crypto523 pushed a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
feat: Configurable base asset (#1339)
a5c209d 
Related issues:
- Closes FuelLabs/fuel-vm#164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvrooman bvrooman

Labels
fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Configurable base asset FuelLabs/fuel-core
4 participants
@Voxelot @mitchmindtree @bvrooman @vlopes11