make registers and memory public #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
previously approved these changes
Dec 15, 2021
Dentosal
approved these changes
Dec 15, 2021
ControlCplusControlV
pushed a commit
that referenced
this pull request
Nov 24, 2022
Add recoverable signature to input coins. The signed message is the transaction hash. Since it can be signed only after the transaction is built, the coin input can only be appended before it is signed since it will define the transaction hash. This created the need to include a `TransactionBuilder` that will accept the arguments of the transaction, and sign the coin inputs after the transaction id is ready. Also, the signed transaction cannot contain the witnesses. These changes are breaking regarding the tests; they now should use the builder structure when input signatures are to be validated.
ControlCplusControlV
pushed a commit
that referenced
this pull request
Nov 24, 2022
ControlCplusControlV
pushed a commit
that referenced
this pull request
Dec 1, 2022
Add recoverable signature to input coins. The signed message is the transaction hash. Since it can be signed only after the transaction is built, the coin input can only be appended before it is signed since it will define the transaction hash. This created the need to include a `TransactionBuilder` that will accept the arguments of the transaction, and sign the coin inputs after the transaction id is ready. Also, the signed transaction cannot contain the witnesses. These changes are breaking regarding the tests; they now should use the builder structure when input signatures are to be validated.
ControlCplusControlV
pushed a commit
that referenced
this pull request
Dec 1, 2022
xgreenx
pushed a commit
that referenced
this pull request
Dec 20, 2022
Add recoverable signature to input coins. The signed message is the transaction hash. Since it can be signed only after the transaction is built, the coin input can only be appended before it is signed since it will define the transaction hash. This created the need to include a `TransactionBuilder` that will accept the arguments of the transaction, and sign the coin inputs after the transaction id is ready. Also, the signed transaction cannot contain the witnesses. These changes are breaking regarding the tests; they now should use the builder structure when input signatures are to be validated.
xgreenx
pushed a commit
that referenced
this pull request
Dec 20, 2022
Add recoverable signature to input coins. The signed message is the transaction hash. Since it can be signed only after the transaction is built, the coin input can only be appended before it is signed since it will define the transaction hash. This created the need to include a `TransactionBuilder` that will accept the arguments of the transaction, and sign the coin inputs after the transaction id is ready. Also, the signed transaction cannot contain the witnesses. These changes are breaking regarding the tests; they now should use the builder structure when input signatures are to be validated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access to these are needed for remote debugging