Memory pool/reuse #732
Merged
Memory pool/reuse #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
xgreenx
reviewed
May 13, 2024
xgreenx
requested changes
May 13, 2024
xgreenx
reviewed
May 13, 2024
xgreenx
reviewed
May 13, 2024
MitchTurner
reviewed
May 13, 2024
xgreenx
reviewed
May 13, 2024
| #[cfg(test)] | ||
| impl<Tx, Ecal> Interpreter<(), Tx, Ecal> | ||
| #[cfg(any(test, feature = "test-helpers"))] | ||
| impl<Tx, Ecal> Interpreter<MemoryFromPool, (), Tx, Ecal> |
There was a problem hiding this comment.
All functions below can just be generic
There was a problem hiding this comment.
Doesn't make much sense, when Default already returns a concrete type.
| @@ -29,19 +30,21 @@ where | |||
| const INC_PC: bool = true; | |||
|
|
|||
| /// ECAL opcode handler | |||
| fn ecal<S, Tx>( | |||
| vm: &mut Interpreter<S, Tx, Self>, | |||
| fn ecal<M, S, Tx>( | |||
There was a problem hiding this comment.
Hmm, I think M, S, and Tx should be generics of the EcalHandler. Otherwise, the implementer doesn't have control over the constraints for these generics. The M: AsRef<Memory> + AsMut<Memory> is an example. What is he needs some contains over the storage?
There was a problem hiding this comment.
Leaving this as a follow-up. #734
Renamed `Memory` into `MemoryInstance`.
# Conflicts: # fuel-vm/src/interpreter/blockchain.rs # fuel-vm/src/interpreter/flow.rs # fuel-vm/src/interpreter/flow/tests.rs
xgreenx
approved these changes
May 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by #732
Adds a method to reset memory to the original state.
Also adds a memory pool to allow reusing memory instances, and use that for all VM initializations.
Checklist
Before requesting review