Add a new mode 2 to the LDC that allows to use the memory as a source for code
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bba89e4.
Added one simple test to check that we can call blobs and they are executed correctly.
Voxelot
reviewed
Oct 5, 2024
Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Voxelot
reviewed
Oct 5, 2024
| let len = len.to_addr()?; | ||
| owner.verify_ownership(&dst_range)?; | ||
|
|
||
| if src_range.end() <= self.stack.len() { |
There was a problem hiding this comment.
Is all the following validation logic new?
There was a problem hiding this comment.
I moved the logic from self.read(src, len) and self.write_noownerchecks(dst, len)? here to avoid to_vec for tmp slice
# Conflicts: # fuel-vm/src/predicate.rs
# Conflicts: # CHANGELOG.md # fuel-vm/src/predicate.rs
AurelienFT
reviewed
Oct 5, 2024
Voxelot
reviewed
Oct 5, 2024
fuel-vm/src/predicate.rs
Outdated
| op::ret(0x0), | ||
| // Good return opcode that we want to use for the `LDC`. | ||
| op::ret(0x1), | ||
| // This will be our zeroed blob id |
Voxelot
reviewed
Oct 5, 2024
fuel-vm/src/predicate.rs
Outdated
| op::move_(0x10, IS), | ||
| // We don't need to copy `jmpf` and bad `ret` opcodes via `LDC`. | ||
| op::addi(0x10, 0x10, 2 * Instruction::SIZE as u16), | ||
| // Store start of the code |
There was a problem hiding this comment.
Suggested change
| // Store start of the code | |
| // Store end of the code |
Voxelot
approved these changes
Oct 5, 2024
AurelienFT
approved these changes
Oct 5, 2024
This was referenced Oct 5, 2024
Merged
Voxelot
added a commit
to FuelLabs/fuel-core
that referenced
this pull request
Oct 5, 2024
## Linked Issues/PRs FuelLabs/fuel-vm#848 FuelLabs/fuel-vm#849 ## Description <!-- List of detailed changes --> ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog - [x] New behavior is reflected in tests - [ ] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [x] I have reviewed the code myself --------- Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu> Co-authored-by: green <xgreenx9999@gmail.com> Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
1 task
Dentosal
added a commit
to FuelLabs/fuel-specs
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Add specification link
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]