Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove elided lifetimes in associated constant #895

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

acerone85
Copy link
Contributor

@acerone85 acerone85 commented Jan 17, 2025

lifetimes_everywhere

Compilation is currently failing locally due to a warning that lifetimes could be elided having be promoted to an error.
See rust-lang/rust#124211

Compilation is also failing because the derivation of proptest_derive::Arbitrary is affected by a reworks of non-local impls
in rust 1.83.0 (see rust-lang/rust#127117 for the rust side, and proptest-rs/proptest#447 for the proptest issue, https://github.com/proptest-rs/proptest/pull/531/files contains a fix).
The problem disappears by bumping proptest_derive to the latest version.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@acerone85 acerone85 requested review from netrome and rafal-ch January 17, 2025 10:28
@acerone85 acerone85 self-assigned this Jan 17, 2025
netrome
netrome previously approved these changes Jan 17, 2025
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

AurelienFT
AurelienFT previously approved these changes Jan 20, 2025
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty !

@acerone85 acerone85 dismissed stale reviews from AurelienFT and netrome via ab73c15 January 21, 2025 14:06
@acerone85 acerone85 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into master with commit acc3c53 Jan 21, 2025
40 checks passed
@acerone85 acerone85 deleted the remove-elided-lifetimes-in-associated-constant branch January 21, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants