Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: some tests are broken due to fixing dependency cycles #877

Closed
iqdecay opened this issue Mar 10, 2023 · 1 comment
Closed

bug: some tests are broken due to fixing dependency cycles #877

iqdecay opened this issue Mar 10, 2023 · 1 comment

Comments

@iqdecay
Copy link
Contributor

iqdecay commented Mar 10, 2023

This example cannot run for instance, because of the fact that we can't import setup_test_provider.
Three alternatives (n°1 is my fav):

  • Remove this example (and the ones like it) altogether, and count on the MDBOOK to do its work
  • Re-introduce the fuels-helpers dependency but re-create a dependency cycle just for having a working example
  • Add the ignore tag to this example, but then it's not tested and easily gets out of sync with the code
@iqdecay iqdecay changed the title test: some tests are broken due to fixing dependency cycles bug: some tests are broken due to fixing dependency cycles Mar 10, 2023
@iqdecay
Copy link
Contributor Author

iqdecay commented Mar 13, 2023

This was inadvertently fixed using n°1 in #848. Can be reopened if necessary.

@iqdecay iqdecay closed this as completed Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant