feat: support returning Vec<> types from contracts
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
digorithm
reviewed
Feb 23, 2023
packages/fuels-code-gen/src/program_bindings/abigen/bindings/function_generator.rs
Show resolved
Hide resolved
|
Review done alongside @hal3e Is returning Vectors from scripts planned as well @digorithm @iqdecay ? |
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
Tracking in #866 |
hal3e
reviewed
Mar 7, 2023
iqdecay
requested review from
a team,
hal3e and
segfault-magnet
and removed request for
hal3e
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
This was referenced Mar 13, 2023
This was referenced Mar 22, 2023
mohammadfawaz
pushed a commit
to FuelLabs/sway
that referenced
this pull request
Apr 12, 2023
- This PR enables returning heap types from scripts. - In FuelLabs/fuels-rs#848, support was added for returning vectors from smart contracts in the SDK, this safeguard can now be removed so the same can happen with scripts.
12 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #746 by allowing the user to return a vector containing any type
from a smart contract.
It relies on one main change:
CALLopcode on the contract now needs the outputtype of the contract call to work properly. Indeed, to know how many bytes
the vector takes in VM memory and return all these bytes, you need to know
the encoding width of the inner type of the vector.