-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new fuel-asm package #987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsjams
requested review from
luizstacio,
LuizAsFight,
arboleya,
Dhaiwat10,
danielbate,
Torres-ssf and
a team
May 8, 2023 04:50
Coverage report
Show new covered files 🐣
Test suite run success885 tests passing in 138 suites. Report generated by 🧪jest coverage report action from f46b291 |
arboleya
reviewed
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting PR! 🤘
I'm still going through everything but would like to understand more about the design decisions—first questions that came to mind:
- There are standalone functions on the
instruction.ts
file:- Should they all be spread into individual
utils/<name>.ts
files? - Should they become static methods of the
Instruction
class? - Should the current approach be kept? If yes, what's the difference between the static methods and the standalone functions?
- Should they all be spread into individual
- Should we break apart the tests from
index.test.ts
and use more descriptive file names, in accordance with their source counterpart? - Should we worry about how big certain files like
opcode.ts
will soon become? For example, there could be 2x files peropcode
(if applicable):/opcodes/<name>.ts
/opcodes/<name>.test.ts
Great stuff! @camsjams
arboleya
approved these changes
May 11, 2023
Dhaiwat10
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #332
This
fuel-asm
package is based off of the Fuel VM implementation, and is the initial implementation to get the ball rolling on support needed to finish a #933In order to complete #933, we plan to duplicate the idea used in the Rust SDK that is documented in FuelLabs/fuels-rs#746 and implemented in FuelLabs/fuels-rs#848, thus requiring some of the features of fuel-asm which was not available in TypeScript.
Note:
I didn't implement all of the opcodes, here's why:
Vec<>
return #933 is time sensitive so I wanted to get through the basics of this support to unblock the Vector changesVec<>
return #933See also: