Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update testnet to beta-3 version #1022

Merged
merged 11 commits into from
Jul 11, 2023
Merged

Conversation

Salka1988
Copy link
Member

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Salka1988 Salka1988 added the documentation Improvements or additions to documentation label Jun 29, 2023
@Salka1988 Salka1988 requested a review from digorithm as a code owner June 29, 2023 09:31
@Salka1988 Salka1988 self-assigned this Jun 29, 2023
@Salka1988 Salka1988 linked an issue Jun 29, 2023 that may be closed by this pull request
@Salka1988 Salka1988 requested a review from SilentCicero June 29, 2023 09:31
digorithm
digorithm previously approved these changes Jun 29, 2023
@Salka1988 Salka1988 enabled auto-merge (squash) June 29, 2023 14:01
hal3e
hal3e previously approved these changes Jun 29, 2023
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the endopoint currently does not work with the SDK because the endpoint uses fuel-core 0.17, unless it was updated. If it doesn't work, we should document it in the docs. Also there are several other instances of the node-beta-2.fuel.network string accross the codebase, those should be changed too (even if they don't work).

@segfault-magnet
Copy link
Contributor

segfault-magnet commented Jul 4, 2023

This doesn't seem blocked?

I'd update all references to beta-3 and add a note specifying what is the latest version that does work with beta-3, as @iqdecay said. That way whoever reads the latest docs will be guided to the right fuels for the testnet.

@Salka1988 Salka1988 removed the blocked label Jul 4, 2023
@Salka1988 Salka1988 dismissed stale reviews from segfault-magnet, hal3e, and digorithm via 39c8257 July 4, 2023 20:37
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make it more clear that it's not going to work unless you use the proper toolchain version. I added a suggestion, feel free to change it.

docs/src/connecting/external-node.md Show resolved Hide resolved
@Salka1988 Salka1988 merged commit 247bb95 into master Jul 11, 2023
@Salka1988 Salka1988 deleted the Salka1988/update_to_beta3 branch July 11, 2023 08:40
iqdecay pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust SDK docs should be updated to beta-3
5 participants