Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add CONTRIBUTING.md #1103

Merged
merged 7 commits into from
Sep 5, 2023
Merged

docs: add CONTRIBUTING.md #1103

merged 7 commits into from
Sep 5, 2023

Conversation

paplo75
Copy link
Contributor

@paplo75 paplo75 commented Aug 27, 2023

Update contributing.md

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Update contributing.md
@CLAassistant
Copy link

CLAassistant commented Aug 27, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ paplo75
❌ iqdecay
You have signed the CLA already but the status is still pending? Let us recheck it.

@Braqzen Braqzen added the documentation Improvements or additions to documentation label Aug 27, 2023
Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brand new account huh, wonder who this is :)

Broadly speaking looks fine. Looks to be potentially duplicated from another repo.
Up to the SDK team but make sure to sign the agreement in the bot message and resolve any CI failures.

@paplo75
Copy link
Contributor Author

paplo75 commented Aug 27, 2023

Brand new account huh, wonder who this is :)

Broadly speaking looks fine. Looks to be potentially duplicated from another repo. Up to the SDK team but make sure to sign the agreement in the bot message and resolve any CI failures.

sir it all about if you accept my contribution to the project. i will sign now. thx

@hal3e hal3e changed the title Update contributing.md chore: update contributing.md Aug 28, 2023
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution -- Left a few typos and wording/phrasing suggestions.

docs/src/contributing/contributing.md Outdated Show resolved Hide resolved
docs/src/contributing/contributing.md Outdated Show resolved Hide resolved
docs/src/contributing/contributing.md Outdated Show resolved Hide resolved
docs/src/contributing/contributing.md Outdated Show resolved Hide resolved
docs/src/contributing/contributing.md Outdated Show resolved Hide resolved
docs/src/contributing/contributing.md Outdated Show resolved Hide resolved
docs/src/contributing/contributing.md Outdated Show resolved Hide resolved
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
@paplo75 paplo75 changed the title chore: update contributing.md CONTRIBUTING.md Aug 28, 2023
@paplo75
Copy link
Contributor Author

paplo75 commented Aug 28, 2023

Thanks for the contribution -- Left a few typos and wording/phrasing suggestions.

all done

iqdecay
iqdecay previously approved these changes Aug 31, 2023
Br1ght0ne
Br1ght0ne previously approved these changes Sep 4, 2023
@Br1ght0ne Br1ght0ne dismissed stale reviews from iqdecay and themself via 655bff6 September 4, 2023 18:37
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paplo75—thanks for your contribution! I went ahead and updated your PR to fix failing CI checks.

@Br1ght0ne Br1ght0ne changed the title CONTRIBUTING.md docs: add CONTRIBUTING.md Sep 4, 2023
@Br1ght0ne Br1ght0ne dismissed digorithm’s stale review September 5, 2023 17:02

all of the suggestions were implemented

@Br1ght0ne Br1ght0ne merged commit 4ae1d29 into FuelLabs:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants