-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add CONTRIBUTING.md #1103
Conversation
Update contributing.md
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brand new account huh, wonder who this is :)
Broadly speaking looks fine. Looks to be potentially duplicated from another repo.
Up to the SDK team but make sure to sign the agreement in the bot message and resolve any CI failures.
sir it all about if you accept my contribution to the project. i will sign now. thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution -- Left a few typos and wording/phrasing suggestions.
Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com>
all done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paplo75—thanks for your contribution! I went ahead and updated your PR to fix failing CI checks.
all of the suggestions were implemented
Update contributing.md
Checklist