fix: pull max gas from provider #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MujkicA
requested review from
digorithm,
iqdecay,
hal3e,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
segfault-magnet
previously approved these changes
Aug 30, 2023
digorithm
previously approved these changes
Aug 30, 2023
Br1ght0ne
previously approved these changes
Aug 30, 2023
chlenc
approved these changes
Aug 30, 2023
MujkicA
dismissed stale reviews from Br1ght0ne, digorithm, and segfault-magnet
via
34d98c1
Br1ght0ne
previously approved these changes
Aug 30, 2023
Salka1988
previously approved these changes
Aug 30, 2023
segfault-magnet
previously approved these changes
Aug 30, 2023
digorithm
previously approved these changes
Aug 30, 2023
segfault-magnet
dismissed stale reviews from digorithm, Salka1988, Br1ght0ne, and themself
via
1ddaf7d
iqdecay
approved these changes
Aug 30, 2023
Salka1988
approved these changes
Aug 30, 2023
digorithm
approved these changes
Aug 30, 2023
segfault-magnet
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta-4 has a max gas limit of 10mil while our dry run tx was using
MAX_GAS_PER_TXwhich was hardcoded to 100mil.With this PR the max value will be retrieved from the consensus parameters.