Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: state read dry run sets gas price to 0 #1494

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: state read dry run sets gas price to 0 #1494

merged 1 commit into from
Aug 23, 2024

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented Aug 22, 2024

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@MujkicA MujkicA added the bug Something isn't working label Aug 22, 2024
@MujkicA MujkicA self-assigned this Aug 22, 2024
Br1ght0ne
Br1ght0ne approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great regression test, LGTM.

digorithm
digorithm approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this so quickly!

packages/fuels-programs/src/calls/call_handler.rs Show resolved Hide resolved
@MujkicA MujkicA merged commit 66210e7 into master Aug 23, 2024
43 checks passed
@MujkicA MujkicA deleted the fix/state-read-gas-price branch August 23, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@hal3e hal3e hal3e approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@digorithm digorithm digorithm approved these changes

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@MujkicA MujkicA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MujkicA @digorithm @Br1ght0ne @hal3e @segfault-magnet