chore!: Move get_asset_outputs_for_amount, get_asset_inputs_for_amount and adjust_for_fee from Account to ViewOnlyAccount
#1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
|
@AurelienFT could you add the proper tag to the title, either chore, feat, or fix please? So the migration script can pick it upon the next release :) Context: #1495 |
AurelienFT
changed the title
get_asset_outputs_for_amount and adjust_for_fee from Account to ViewOnlyAccountget_asset_outputs_for_amount and adjust_for_fee from Account to ViewOnlyAccount
Done :) |
AurelienFT
changed the title
get_asset_outputs_for_amount and adjust_for_fee from Account to ViewOnlyAccountget_asset_outputs_for_amount and adjust_for_fee from Account to ViewOnlyAccount
AurelienFT
changed the title
get_asset_outputs_for_amount and adjust_for_fee from Account to ViewOnlyAccountget_asset_outputs_for_amount, get_asset_inputs_for_amount and adjust_for_fee from Account to ViewOnlyAccount
AurelienFT
changed the title
get_asset_outputs_for_amount, get_asset_inputs_for_amount and adjust_for_fee from Account to ViewOnlyAccountget_asset_outputs_for_amount, get_asset_inputs_for_amount and adjust_for_fee from Account to ViewOnlyAccount
…e_method_from_account_to_view_only_account
|
This PR is based on #1496 This PR can't be merged for now as it contains breaking changes and |
AurelienFT
removed request for
digorithm,
Salka1988,
MujkicA,
hal3e and
segfault-magnet
|
@AurelienFT Is this still a draft, or are we good to review it? |
Yes sorry I placed it to draft to avoid merging before :p |
Br1ght0ne
approved these changes
Sep 7, 2024
MujkicA
approved these changes
Sep 10, 2024
AurelienFT
deleted the
move_method_from_account_to_view_only_account
branch
hal3e
added a commit
that referenced
this pull request
Sep 13, 2024
…ount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` (#1498) # Release notes In this release, we: - Move `get_asset_outputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` # Summary This PR moves `get_asset_outputs_for_amount`, `get_asset_inputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` trait. It seem that these two methods doesn't require a full `Account` and so it give more flexibility in order to implement them in other structures such as `Wallet`. Now `Wallet` also implement these two methods. Before you were forced to build a `WalletUnlocked` even if you don't use the `secret_key`. # Breaking changes This contains an API breaking change as some public trait as been edited: # Breaking Changes The provider option flag `cacheUtxo` was renamed to `resourceCacheTTL` ```rust // before use fuels::acounts::Account; wallet.get_asset_outputs_for_amount(...); ``` ```rust // after use fuels::acounts::ViewOnlyAccount; wallet.get_asset_outputs_for_amount(...); ``` # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none) --------- Co-authored-by: hal3e <git@hal3e.io> Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com> Co-authored-by: MujkicA <ahmedmujkic2@gmail.com>
hal3e
added a commit
that referenced
this pull request
Nov 6, 2024
…ount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` (#1498) # Release notes In this release, we: - Move `get_asset_outputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` # Summary This PR moves `get_asset_outputs_for_amount`, `get_asset_inputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` trait. It seem that these two methods doesn't require a full `Account` and so it give more flexibility in order to implement them in other structures such as `Wallet`. Now `Wallet` also implement these two methods. Before you were forced to build a `WalletUnlocked` even if you don't use the `secret_key`. # Breaking changes This contains an API breaking change as some public trait as been edited: # Breaking Changes The provider option flag `cacheUtxo` was renamed to `resourceCacheTTL` ```rust // before use fuels::acounts::Account; wallet.get_asset_outputs_for_amount(...); ``` ```rust // after use fuels::acounts::ViewOnlyAccount; wallet.get_asset_outputs_for_amount(...); ``` # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none) --------- Co-authored-by: hal3e <git@hal3e.io> Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com> Co-authored-by: MujkicA <ahmedmujkic2@gmail.com>
hal3e
added a commit
that referenced
this pull request
Nov 22, 2024
…ount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` (#1498) # Release notes In this release, we: - Move `get_asset_outputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` # Summary This PR moves `get_asset_outputs_for_amount`, `get_asset_inputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` trait. It seem that these two methods doesn't require a full `Account` and so it give more flexibility in order to implement them in other structures such as `Wallet`. Now `Wallet` also implement these two methods. Before you were forced to build a `WalletUnlocked` even if you don't use the `secret_key`. # Breaking changes This contains an API breaking change as some public trait as been edited: # Breaking Changes The provider option flag `cacheUtxo` was renamed to `resourceCacheTTL` ```rust // before use fuels::acounts::Account; wallet.get_asset_outputs_for_amount(...); ``` ```rust // after use fuels::acounts::ViewOnlyAccount; wallet.get_asset_outputs_for_amount(...); ``` # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none) --------- Co-authored-by: hal3e <git@hal3e.io> Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com> Co-authored-by: MujkicA <ahmedmujkic2@gmail.com>
hal3e
added a commit
that referenced
this pull request
Jan 7, 2025
…ount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` (#1498) # Release notes In this release, we: - Move `get_asset_outputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` # Summary This PR moves `get_asset_outputs_for_amount`, `get_asset_inputs_for_amount` and `adjust_for_fee` from `Account` to `ViewOnlyAccount` trait. It seem that these two methods doesn't require a full `Account` and so it give more flexibility in order to implement them in other structures such as `Wallet`. Now `Wallet` also implement these two methods. Before you were forced to build a `WalletUnlocked` even if you don't use the `secret_key`. # Breaking changes This contains an API breaking change as some public trait as been edited: # Breaking Changes The provider option flag `cacheUtxo` was renamed to `resourceCacheTTL` ```rust // before use fuels::acounts::Account; wallet.get_asset_outputs_for_amount(...); ``` ```rust // after use fuels::acounts::ViewOnlyAccount; wallet.get_asset_outputs_for_amount(...); ``` # Checklist - [x] All **changes** are **covered** by **tests** (or not applicable) - [x] All **changes** are **documented** (or not applicable) - [x] I **reviewed** the **entire PR** myself (preferably, on GH UI) - [x] I **described** all **Breaking Changes** (or there's none) --------- Co-authored-by: hal3e <git@hal3e.io> Co-authored-by: Rodrigo Araújo <rod.dearaujo@gmail.com> Co-authored-by: MujkicA <ahmedmujkic2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
get_asset_outputs_for_amountandadjust_for_feefromAccounttoViewOnlyAccountSummary
This PR moves
get_asset_outputs_for_amount,get_asset_inputs_for_amountandadjust_for_feefromAccounttoViewOnlyAccounttrait. It seem that these two methods doesn't require a fullAccountand so it give more flexibility in order to implement them in other structures such asWallet.Now
Walletalso implement these two methods. Before you were forced to build aWalletUnlockedeven if you don't use thesecret_key.Breaking changes
This contains an API breaking change as some public trait as been edited:
Breaking Changes
The provider option flag
cacheUtxowas renamed toresourceCacheTTLChecklist