-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: script and predicate blobs #1520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
segfault-magnet
requested review from
digorithm,
hal3e,
MujkicA,
Salka1988 and
Br1ght0ne
as code owners
October 5, 2024 03:05
Br1ght0ne
previously approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as I saw most of it being written ;)
MujkicA
previously approved these changes
Oct 6, 2024
digorithm
previously approved these changes
Oct 6, 2024
hal3e
previously approved these changes
Oct 6, 2024
segfault-magnet
dismissed stale reviews from hal3e, digorithm, and MujkicA
via
October 6, 2024 00:54
7f4af23
hal3e
approved these changes
Oct 6, 2024
MujkicA
approved these changes
Oct 6, 2024
digorithm
approved these changes
Oct 6, 2024
Br1ght0ne
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1519
Waiting for a fuel-core release to remove all the patches in Cargo.toml
Release notes
In this release, we:
Summary
Added a
Executable
type which can be given a Sway binary and be used to turn it into loader code.All script/predicate code except their data sections is uploaded as a blob and referenced in the loader code.
Every loader code execution can be configured differently without the need of large transactions due to the rest of the code being uploaded beforehand as a blob.
Checklist