-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-tagged version of forc in CI #699
Conversation
# Conflicts: # .github/workflows/ci.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the code and think it looks godd! I'm just not sure how we would use it in reality. Can you provide more explanation?
If I understood correctly, we need the option to use the FORC_PATCH_BRANCH = "Salka1988/new_unreleased_forc_on_some_branch" This will install version from the branch and use it in CI. Same with revision number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. I've never needed to use an unreleased force version in the CI, but if that's a real need, then adding the option to support this doesn't hurt.
Did not demand changes, but an explanation
added flags FORC_PATCH_BRANCH and FORC_PATCH_REVISION in CI
flag FORC_PATCH_BRANCH allows CI to use the
forc
version found on the given branchflag FORC_PATCH_REVISION allows CI to use a
forc
version that is behind an existing rev. number